Bryan Tong Minh [Sat, 12 Mar 2011 22:51:45 +0000 (22:51 +0000)]
Follow-up r83792: Remove left in debugging
Bryan Tong Minh [Sat, 12 Mar 2011 22:50:43 +0000 (22:50 +0000)]
Follow-up r83778: Need to de-rotate, so use 360 - angle instead of angle.
Bryan Tong Minh [Sat, 12 Mar 2011 22:49:31 +0000 (22:49 +0000)]
(bug 2581, bug 6834) Added links to thumbnail in several resolutions to the file description page. The sizes are set by $wgImageLimits.
Not really happy about how it looks, perhaps only the numbers should be linked? See http://www.mediawiki.org/wiki/User:Bryan/Bug_2581 for options.
Removed message show-big-image-thumb, added show-big-image-preview, show-big-image-other, show-big-image-size.
Happy-melon [Sat, 12 Mar 2011 22:48:58 +0000 (22:48 +0000)]
Follow-up r83786, try to keep the svn history of SpecialBlockip. This rev will be broken.
Happy-melon [Sat, 12 Mar 2011 22:42:58 +0000 (22:42 +0000)]
Spin out all the CSS used on special pages into their own mediawiki.special module. This comprises about a third of /skins/common/shared.css, so it's definitely worthwhile not loading it for the 99.9% of pageviews which aren't special pages.
Sam Reed [Sat, 12 Mar 2011 22:23:43 +0000 (22:23 +0000)]
* (bug 28010) Passing a non existant user to list=users gives internal error
* (bug 27549) action=query&list=users&usprop=groups doesn't show implicit groups if a user doesn't have explicit groups
Also follows up r79556, where I'd done a couple of daft things... (accessing undefined objects)
Happy-melon [Sat, 12 Mar 2011 21:54:35 +0000 (21:54 +0000)]
Divert a river through the Augean Stables that is SpecialBlockip.php.
* Move to SpecialBlock.php, and rename class appropriately
* Complete refactor
* Use HTMLForm in block form. This changes most of the ids and field names on the form, but allows proper validation, nicer formatting, clears up several fixmes, and is generally Better(TM).
* Spin various parts out into static functions, several of which properly belong in the backend (but Block.php is a worse mess still)
* Invert some of the block options so that every checkbox makes the block more severe (so "check to disable email" is fine, but "check to allow usertalk edit" (default true) is inverted to "check to disable usertalk edit" (default false).
* revert r40359 (move doMassUserBlock() to core). No one seems to be using this function, which has nothing to do with the frontend UI in SpecialBlock (it might perhaps belong in Block.php); it is pretty bespoke for CheckUser, doesn't seem to have very much utility elsewhere.
Bryan Tong Minh [Sat, 12 Mar 2011 21:35:27 +0000 (21:35 +0000)]
Fix switch fail in r83778: add missing break.
Raimond Spekking [Sat, 12 Mar 2011 21:02:43 +0000 (21:02 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-03-12 20:34:00 UTC)
Happy-melon [Sat, 12 Mar 2011 20:47:52 +0000 (20:47 +0000)]
Follow-up r83747, forgot to commit a file
Rotem Liss [Sat, 12 Mar 2011 20:11:19 +0000 (20:11 +0000)]
Localization fix for he.
Bryan Tong Minh [Sat, 12 Mar 2011 19:59:41 +0000 (19:59 +0000)]
(bug 18691) Added support for SVG rasterization using the Imagick PHP extension. Based on patch by Yesid Carrillo. Set $wgSVGConverter = 'ImagickExt' to use it. Note that the results are extremely ugly, but I believe that happens with the command line scaler as well.
Introduced new syntax for $wgSVGConverters, if the selected converter is an array, it is assumed to be a PHP callable. Imagick support is done by SvgHandler::rasterizeImagickExt.
Bryan Tong Minh [Sat, 12 Mar 2011 19:32:39 +0000 (19:32 +0000)]
(bug 14706) Added support for the Imagick PHP extension. Based on patch by Leslie Hoare.
Scaler type is "imext". Rotation is supported.
Logic mostly copied from transformImagemagick() and ported to Imagick calls.
Resizing animated gifs is broken; it only shows the first frame and I can't find out why it does not work, but otherwise it is fully working.
Happy-melon [Sat, 12 Mar 2011 18:51:51 +0000 (18:51 +0000)]
RELEASE-NOTES for r83755
Happy-melon [Sat, 12 Mar 2011 18:14:33 +0000 (18:14 +0000)]
Follow-up r83755: @deprecated @since is wrong, doesn't have the expected semantic meaning.
Alexandre Emsenhuber [Sat, 12 Mar 2011 14:21:41 +0000 (14:21 +0000)]
Skip a part of useless code when redirecting because of getOldIDFromRequest() or showing a diff page
Alexandre Emsenhuber [Sat, 12 Mar 2011 13:45:12 +0000 (13:45 +0000)]
Use Html::element() to generate the element; the url and the title attribute are now build only when really necessary
Raimond Spekking [Sat, 12 Mar 2011 13:42:22 +0000 (13:42 +0000)]
Follow-up r83755: Message 'ipaddress' is unused now, in core and extensions
Happy-melon [Sat, 12 Mar 2011 12:13:22 +0000 (12:13 +0000)]
Deprecate $wgSysopUserBans and $wgSysopRangeBans, both of which are pre-1.2, and totally antiquated. Can't think of any reason why a modern wiki might want to make blocks IP-only; syadmins can still disable rangeblocks by setting $wgBlockCIDRLimit to the maximum for each IP mode (32 for IP4, 128 for IP6).
Aaron Schulz [Sat, 12 Mar 2011 11:51:33 +0000 (11:51 +0000)]
Do the filearchive updates too; index is there now
Happy-melon [Sat, 12 Mar 2011 11:08:20 +0000 (11:08 +0000)]
Follow-up r83298: keep the two elements of the message separate in an array in HTMLSelectAndOtherField::loadDataFromRequest(), fixes various bugs with validation, defaults, and normalisation.
Happy-melon [Fri, 11 Mar 2011 23:42:53 +0000 (23:42 +0000)]
add __toString() call for User objects, returning User->getName(). Now that we require PHP 5.2+, we can do this with all our major classes... :D
Happy-melon [Fri, 11 Mar 2011 23:33:36 +0000 (23:33 +0000)]
First little bit of cleaning out the Augean stables of SpecialBlockip.php: spin out the suppressUserName/unsuppressUserName functions into their own file, to keep them with the rest of the RevDel stuff.
Aryeh Gregor [Fri, 11 Mar 2011 21:01:46 +0000 (21:01 +0000)]
Remove HISTORY for r70526
Removed from 1.17 RELEASE-NOTES in r83720.
Raimond Spekking [Fri, 11 Mar 2011 20:59:31 +0000 (20:59 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-03-11 20:34:00 UTC)
Aryeh Gregor [Fri, 11 Mar 2011 20:50:17 +0000 (20:50 +0000)]
Normalize named entities to numeric
We should never be outputting named entities other than the ones in XML,
< > & ", because that will break well-formedness unless
we have a DTD in the doctype, which we don't in HTML5 mode.
I stuck with outputting numeric entities here instead of UTF-8 because
some characters are hard to read in UTF-8 (e.g., ). Maybe it
would be nicer if we decoded to UTF-8 except for whitespace and control
characters, or something like that, but it's a detail.
I'll backport to 1.17 and add RELEASE-NOTES there, which is why I added
the line to HISTORY instead of RELEASE-NOTES.
Alexandre Emsenhuber [Fri, 11 Mar 2011 20:04:17 +0000 (20:04 +0000)]
Follow-up r83080: make ApiUploadTest really work this time
Happy-melon [Fri, 11 Mar 2011 18:02:10 +0000 (18:02 +0000)]
Follow-up r83298: add AutoLoader entry
Alexandre Emsenhuber [Fri, 11 Mar 2011 14:31:12 +0000 (14:31 +0000)]
Only call User::getSkin() when necessary.
(With this, a parser cache hit on action=render may not load the skin at all)
Aryeh Gregor [Fri, 11 Mar 2011 02:10:00 +0000 (02:10 +0000)]
Allow all itemtypes for microdata
It's really not all that useful otherwise.
Trevor Parscal [Fri, 11 Mar 2011 00:12:25 +0000 (00:12 +0000)]
Fixes bug #27979 by removing 2 unused arguments from the function declaration. These were an artifact of splitting the recurse and resolve functions.
Sam Reed [Thu, 10 Mar 2011 23:14:50 +0000 (23:14 +0000)]
remved?
Alexandre Emsenhuber [Thu, 10 Mar 2011 21:39:24 +0000 (21:39 +0000)]
Per Jarry1250 on IRC: fix for r81469: accept StubObject in Message::inLanguage(); was breaking api.php?action=query&meta=allmessages
Raimond Spekking [Thu, 10 Mar 2011 21:02:36 +0000 (21:02 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-03-10 20:05:00 UTC)
Antoine Musso [Thu, 10 Mar 2011 20:24:04 +0000 (20:24 +0000)]
Makes MediaWikiProvide methods static
Follow up and revert r82369 which used dynamic calls
Krinkle [Thu, 10 Mar 2011 18:49:14 +0000 (18:49 +0000)]
Fixing minor issues with mw.loader
* Using $.isArray/isFunction instead of "instanceof" or typeof.
** "instanceof Array" can throw SyntaxErrors in some cases
** Some non-functions return 'function' as their type
* JSHint:
** using === to compare to null (faster and safer)
** Missing semicolons
** Mixed spaces with tabs
* Added mw.log call when module is loaded
* Added support for custom prefix to mw.log (the mw.config value for 'mw.log.prefix' is pretty ugly as it sets it globally, when calling a function later again it's no longer the same. Perhaps just get rid of it)
Krinkle [Thu, 10 Mar 2011 17:38:21 +0000 (17:38 +0000)]
Fixing minor issues in mw.htmlform
* jQuery should be mapped to $ before using it. $ should not be implied as global in-core. ("return $(this).show()" was using $ as global)
** added wrapper and replaced jQuery with $.
* Missing semicolon
Chad Horohoe [Thu, 10 Mar 2011 15:12:36 +0000 (15:12 +0000)]
(bug 27970) Wrong variable name, dependencies -> modules
Bryan Tong Minh [Thu, 10 Mar 2011 12:04:38 +0000 (12:04 +0000)]
Revert r83647, was based on the inability to read the function signature
Bryan Tong Minh [Thu, 10 Mar 2011 12:02:35 +0000 (12:02 +0000)]
Add wfObjectToArray to json_decode to ensure that the return value is an array
Tim Starling [Thu, 10 Mar 2011 11:39:23 +0000 (11:39 +0000)]
Fix duplicate removal. Was completely broken, with a "job_id IS NULL" condition in the delete query. Added a COMMIT to pop_type().
Tim Starling [Thu, 10 Mar 2011 05:26:34 +0000 (05:26 +0000)]
Add --maxtime parameter to allow job runners to be limited by time instead of job count. This makes more sense when --procs is used. Using it on Wikimedia will reduce the effect of laggy slaves.
Tim Starling [Thu, 10 Mar 2011 04:47:21 +0000 (04:47 +0000)]
Some bug fixes for r83634.
Tim Starling [Thu, 10 Mar 2011 04:10:27 +0000 (04:10 +0000)]
Rewrite the caching code in nextJobDB.php so that jobs-loop.sh has a chance of being able to exit from the "high-priority" loop.
The current syndrome is that when the cache expires, a small number of high-priority jobs are added. These jobs are quickly cleared, but the job runners do not continue on to other things, because the cache keeps returning the same small list of wikis for 5 minutes. After 5 minutes, there are a few more jobs in the high-priority list, so the cycle continues.
Tim Starling [Thu, 10 Mar 2011 02:27:15 +0000 (02:27 +0000)]
Stats for duplicate removal
Ryan Kaldari [Thu, 10 Mar 2011 00:25:33 +0000 (00:25 +0000)]
fix for Bug 27669
Neil Kandalgaonkar [Thu, 10 Mar 2011 00:14:36 +0000 (00:14 +0000)]
fixed some parseInts to have a base, renamed a var from number -> num since number is reserved
Tim Starling [Thu, 10 Mar 2011 00:00:34 +0000 (00:00 +0000)]
* Add a $count argument to wfIncrStats(), to allow it to increase the count by more than one at a time.
* Added stats to job insert and pop.
* Formalised live patch for UDP stats aggregation, adding $wgAggregateStatsID.
Raimond Spekking [Wed, 9 Mar 2011 22:15:15 +0000 (22:15 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-03-09 21:26:00 UTC)
Krinkle [Wed, 9 Mar 2011 21:50:00 +0000 (21:50 +0000)]
Escape minus in $.escapeRE
* Follow-up r83287: Removing slash before caret(^), apparently not needed.
* Escaping minus (-), adding the minus symbol (added in r83284), causes all uppercase characters and numbers to be escaped:
(bug 27960) $.escapeRE shouldn't escape all uppercase and numbers
* Added more compelete tets to the JS Test Suite for $.escapeRE to avoid problems in the future
Sam Reed [Wed, 9 Mar 2011 17:57:32 +0000 (17:57 +0000)]
Per CR, swap Jarry1250 to Harry Burt
Rotem Liss [Wed, 9 Mar 2011 17:30:22 +0000 (17:30 +0000)]
Localization update for he, and whitespace fixes in en.
Sam Reed [Wed, 9 Mar 2011 17:09:10 +0000 (17:09 +0000)]
More function/member variable documentation
Sam Reed [Wed, 9 Mar 2011 16:37:39 +0000 (16:37 +0000)]
Followup r83558, r83555
Set default of false to $open parameter
Roan Kattouw [Wed, 9 Mar 2011 14:27:13 +0000 (14:27 +0000)]
Fix r83586 (drag and drop support for placeholder plugin) to work in IE, whose drag&drop API is surprisingly similar to Firefox's but with slight differences
Roan Kattouw [Wed, 9 Mar 2011 13:54:02 +0000 (13:54 +0000)]
(bug 27944) Search placeholder was inserted even when the search box was already focused, leading to the placeholder being added to the search string. This revision doesn't fix the initial insertion of the placeholder if the search box is focused but empty, but it does remove it upon keydown (and paste), which fixes the search string munging.
(bug 26135) Support drag and drop in the search box in Firefox. Done by adding 'drop' to the list of events to update search suggestions for and to remove the placeholder for. Removing the placeholder is trickier in this case because 'drop' fires after the text has already been inserted, and because it could have been inserted at any offset in the placeholder string. Used dataTransfer magic to obtain the text being dropped and just overwrote the search box text with that.
Roan Kattouw [Wed, 9 Mar 2011 12:30:08 +0000 (12:30 +0000)]
Fix r74388: CSS for IE7 and below was put in a selector that only applies it for IE7 and *above*, causing bug 27547 (Text excerpt doesn't start on a new line in file search results) in other browsers. Fixed this by replacing the selector hack with !ie , a hack that we use to target IE7 and below with our data URL embedding fallback as well
Antoine Musso [Wed, 9 Mar 2011 07:12:19 +0000 (07:12 +0000)]
typo / space fix in HTTP class
Roan Kattouw [Wed, 9 Mar 2011 01:13:17 +0000 (01:13 +0000)]
Merge r83652 from 1.17wmf1 to trunk: add backwards compatibility from &from= and &until= on category pages to keep things like alphabet templates working
Roan Kattouw [Wed, 9 Mar 2011 00:24:21 +0000 (00:24 +0000)]
Merge r83555 from 1.17wmf1: fix wait for slaves code from r83529
Sam Reed [Wed, 9 Mar 2011 00:24:17 +0000 (00:24 +0000)]
Alphasort credits from r83554
Ilmari Karonen [Wed, 9 Mar 2011 00:06:57 +0000 (00:06 +0000)]
(bug 14645) Show expensive special pages differently in miser mode on Special:SpecialPages. Patch by Jarry1250 with a few tweaks by me. Tested, saw no errors or warnings.
Aryeh Gregor [Tue, 8 Mar 2011 21:21:08 +0000 (21:21 +0000)]
Change collationUpdate batch size from 1000 to 50
It selects that many rows, then does PHP processing and an individual
update query for each one. This is not a good idea when each batch is
done in a single transaction: 1000 MySQL updates interspersed with PHP
processing might take a second or more while locks are held.
Aryeh Gregor [Tue, 8 Mar 2011 20:49:35 +0000 (20:49 +0000)]
Don't regenerate raw sortkeys in CategoryPage.php
Previously, when adding pages, we'd use $title->getCategorySortkey(
$row->cl_sortkey_prefix ) to generate the initial letter on category
pages. This is fine if the migration script has already been run, but
until then, cl_sortkey_prefix will always be the empty string, so the
user-specified sortkey will be ignored when generating initial letters.
Plus, if getCategorySortkey() had nontrivial computational cost, this
would be a waste of resources.
So just use $row->cl_sortkey instead. This is at least guaranteed to be
consistent with how pagination works, no matter what state the DB is in.
Already deployed by Roan to fix user bug reports in #wikimedia-tech,
from apergos, Alpha_Quadrant, and Romaine. Tested on Wikimedia, so far
so good.
Sam Reed [Tue, 8 Mar 2011 20:17:48 +0000 (20:17 +0000)]
More documentation and class definitions
Few tweaks to braces
Mark A. Hershberger [Tue, 8 Mar 2011 18:12:17 +0000 (18:12 +0000)]
misc w/s cleanups, “svn diff -x-w” clean
Mark A. Hershberger [Tue, 8 Mar 2011 18:09:34 +0000 (18:09 +0000)]
* Followup r76127 and r83521 by adding parsertests and using caseFold
Alexandre Emsenhuber [Tue, 8 Mar 2011 18:01:17 +0000 (18:01 +0000)]
* Update class name: FakeMemCachedClient -> EmptyBagOStuff
* Don't show "Division by zero" warnings when there's no statistics for cache hits
Roan Kattouw [Tue, 8 Mar 2011 16:47:26 +0000 (16:47 +0000)]
Make updateCollation.php a bit less murderous for WMF databases:
* Don't run a COUNT(*) query on what's potentially the entire categorylinks table on enwiki (hundreds of millions of rows). Put it in a miser mode check
* Wait for DB replication to catch up before processing the next batch. Implemented LoadBalancer::waitAll() for this purpose, which should behave more nicely than wfWaitForSlaves()
Ilmari Karonen [Tue, 8 Mar 2011 15:54:28 +0000 (15:54 +0000)]
revert r83521; this needs to be fixed better, but fixing the crash is first priority
Mark A. Hershberger [Tue, 8 Mar 2011 14:38:26 +0000 (14:38 +0000)]
followup r76127 — use language-aware comparison between link text and possible title attribute
Max Semenik [Tue, 8 Mar 2011 09:28:13 +0000 (09:28 +0000)]
LocalSettings generation tweaks:
* Mention extensions only if user chose some during installation
* Added a comment at the bottom suggesting where to put new settings
Antoine Musso [Tue, 8 Mar 2011 07:27:18 +0000 (07:27 +0000)]
switch 'column' for 'colon'
I always thought the colon and semicolon punctuation marks were named after
their architectural equivalent: column. At least, to me, it made more sens
than using a term relating to thedigestive system.
Per Nikerabbit r83296
Tim Starling [Tue, 8 Mar 2011 06:38:15 +0000 (06:38 +0000)]
Set $wgInternalServer to false by default, and fall back to $wgServer in the referring code. This avoids having squid updates break when $wgServer is set in configuration but $wgInternalServer is neglected. For immediate deployment, tested locally.
Sam Reed [Tue, 8 Mar 2011 02:40:09 +0000 (02:40 +0000)]
Last few svn property fixes
Sam Reed [Tue, 8 Mar 2011 02:25:12 +0000 (02:25 +0000)]
And some more mime-types
Trevor Parscal [Tue, 8 Mar 2011 02:02:27 +0000 (02:02 +0000)]
* Increased the size of the tipsy callout, removed the shadow and made the background of tips white to try and improve the visibility of tips.
* Added ui-button-green, ui-button-blue, ui-button-red classes to the Vector jquery ui theme
Platonides [Tue, 8 Mar 2011 00:20:26 +0000 (00:20 +0000)]
Comment the var_dump() and add a comment.
Follow up r83208.
Sam Reed [Mon, 7 Mar 2011 22:58:26 +0000 (22:58 +0000)]
Fix r83390, need to do where ipb_deleted IS NULL as we're left joining in the table, so it can be null
Duh
Krinkle [Mon, 7 Mar 2011 21:17:47 +0000 (21:17 +0000)]
removing fallback, not needed (messages are in-core and defined in Resources.php). FU: r78966
Sam Reed [Mon, 7 Mar 2011 20:42:55 +0000 (20:42 +0000)]
Strip cookie classes out of the middle of HttpFunctions.php into Cookie.php using svn copy
Raimond Spekking [Mon, 7 Mar 2011 20:21:17 +0000 (20:21 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-03-07 19:38:00 UTC)
Raimond Spekking [Mon, 7 Mar 2011 20:03:32 +0000 (20:03 +0000)]
Follow-up r83292/r83310: Add new message to the maintenance file too
Platonides [Mon, 7 Mar 2011 19:13:19 +0000 (19:13 +0000)]
Merge corrected r81741 and resolve the TODO.
Keep disabled with a class constant.
Max Semenik [Mon, 7 Mar 2011 18:45:43 +0000 (18:45 +0000)]
Bug 27920 - Installer sets $wgUseImageMagick = true even when IM is not found
Alexandre Emsenhuber [Mon, 7 Mar 2011 18:21:58 +0000 (18:21 +0000)]
* Make Skin::formatDebugHTML() work with $wgDebugTimestamps = true
* Removed escaping of ' since the string is defined with "
Bryan Tong Minh [Mon, 7 Mar 2011 17:17:57 +0000 (17:17 +0000)]
Follow-up r83461, replace deleted with hidden and reverse the word, e.g. deletedfile->filehidden. Consistency with prop=revision etc. (In Soviet-Russia, file hides you!)
Antoine Musso [Mon, 7 Mar 2011 17:10:22 +0000 (17:10 +0000)]
Remove second parameters from wfEmptyMsg() calls
The second parameter was removed in r64178 and is now useless.
There is probably no need to backport this in 1.17.
Bryan Tong Minh [Mon, 7 Mar 2011 17:07:10 +0000 (17:07 +0000)]
(bug 27722) list=filearchive now supports revdel
* Adds a condition fa_deleted=0 if the user does not have the suppressrevision rights. This field is unindexed. This should however not be a big problem as files with fa_deleted are rare. Unfortunately this hides files that do not have DELETED_RESTRICTED, but I don't know how bad fa_deleted & DELETED_RESTRICTED = 0 is for performance
* Added deletedfile, deletedcomment, deleteduser and deletedrestricted to the output for what I think are appropriate fa_deleted fields, but it's hard to tell what's corrent without a single line of documentation or even comment in the code. Perhaps somebody can dig up a commit message where the purpose of the constants is explained?
Antoine Musso [Mon, 7 Mar 2011 16:36:35 +0000 (16:36 +0000)]
Keep monospace as a fallback for HTML debugging
Per CR on r83336. We also keep this as inline style since it is only
needed by developers anyway.
Sam Reed [Mon, 7 Mar 2011 14:59:41 +0000 (14:59 +0000)]
More documentation
Remove trailing whitespace
Sam Reed [Mon, 7 Mar 2011 14:45:11 +0000 (14:45 +0000)]
Documentation and explicit variable definitions
Followup r80069, swap private to protected
Siebrand Mazeland [Mon, 7 Mar 2011 12:13:14 +0000 (12:13 +0000)]
Rephrase 'config-using531' per suggestion of Krinkle: "Granted the bug is in PHP, but imho "PHP" isn't compatible with MediaWiki, it's the other way around."
Also removed the link to the PHP bug report. Not that relevant for the user installing MediaWiki.
Platonides [Sun, 6 Mar 2011 23:29:29 +0000 (23:29 +0000)]
Reorder so that wfProfileOut() is the last sentence before the return.
Platonides [Sun, 6 Mar 2011 23:28:32 +0000 (23:28 +0000)]
Remove unused globals
Krinkle [Sun, 6 Mar 2011 23:25:33 +0000 (23:25 +0000)]
Fix for IE7, jQuery magic doesn't help here, it needs to be valid html, shorthand doesn't work in all browsers
Platonides [Sun, 6 Mar 2011 23:15:10 +0000 (23:15 +0000)]
r82867 converted $wgCaches into a class instance. Update the parsertests.
This faking is needed to avoid Table 'unittest_objectcache' doesn't exist errors when using temporary tables.
Platonides [Sun, 6 Mar 2011 23:07:36 +0000 (23:07 +0000)]
Follow up r83140. Add a clear() method to ObjectCache so that it can be used by ForkController.
Bryan Tong Minh [Sun, 6 Mar 2011 22:16:34 +0000 (22:16 +0000)]
Kill filtering by hash because the query is unindexed. We need a condition on fa_storage_group, but I'm not sure how index merging will work out. I don't have time to investigate this at the moment, so killing it in its entirety seems the safest option for now.
Bryan Tong Minh [Sun, 6 Mar 2011 22:03:45 +0000 (22:03 +0000)]
Breaking change: remove faminsize/famaxsize because they lead to an unindexed query, which takes a very long time if there are only few rows that match the filter. Introduced in r66168, so luckily only live since 1.17.